5/6/2019»»Monday

gurusgreat

How To Open Application Octet Stream

5/6/2019
    48 - Comments

Please enable JavaScript in your browser to use all the features on this site.

Status

For problems with mail or news message attachments.
RESOLVED WORKSFORME
11 years ago
2 months ago

Tracking

(Blocks 1 bug)

1.9.1 Branch
---
Dependency tree / graph

Details

(Whiteboard: [needs slightly updated patch])

: review+
: superreview-
Details Diff Splinter Review
94.45 KB, text/plain; charset='iso-8859-1'
Details
11.07 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document
Details
Details Diff Splinter Review
Posted patch Fixes the content-type depending on the file extension (obsolete) — Details — Splinter Review
Status: UNCONFIRMED → NEW
Posted patch Override content-type by file name extension (obsolete) — Details — Splinter Review
Attachment #339937 - Flags: review?(dmose)
Flags: wanted-thunderbird3+
Target Milestone: --- → Thunderbird 3.0b2
Posted patch patch, v3 (obsolete) — Details — Splinter Review
Attachment #371779 - Flags: review?(dmose)
Attachment #371779 - Flags: review?(dmose) → review+
Posted patch patch, v4 — Details — Splinter Review
Attachment #371950 - Flags: superreview?(bienvenu)
Whiteboard: [has patch, needs review dmose] → [has patch, needs sr bienvenu]
Attachment #371950 - Flags: superreview?(bienvenu) → superreview-
Whiteboard: [has patch, needs sr bienvenu] → [needs updated patch]
Hardware: x86 → All
Whiteboard: [needs updated patch] → [needs slightly updated patch]
Target Milestone: Thunderbird 3.0b2 → Thunderbird 3.1a1
Product: Thunderbird → MailNews Core
Target Milestone: Thunderbird 3.1a1 → ---
Posted file Sample .eml with PDF attachment originally from M$Windows XP + Tb10 workstation — Details
Attachment #608787 - Attachment mime type: application/octet-stream → text/plain
Attachment #608787 - Attachment mime type: text/plain → text/plain; charset='iso-8859-1'
Summary: PDF attachments with content-type octet-stream are handled bad → PDF attachments with Content-Type: application/octet-stream are handled bad
Keywords: qawanted

aceman, see questions in comment 33

Keywords: qawanted

So funny, application/octet-stream works in a local mailbox, for sure. But on IMAP, that's a different story and it DOES NOT WORK, see bug 1418444.

Gene, you were experimenting in bug 1418444. Please take a look at the patch here, they look OK to me, we just need to fix the issue from comment #17.

I have a sample email that has 2 pdfs attached, one with application/octet-stream and the other with application/pdf. Both seem to open OK with no prompt for 'which app do you want to open this file with?'. Opens right up into a linux pdf app called 'okular'.

This is with an imap folder with no offline storage (mem cache only) and with and without attachments set inline (not that it would matter with a pdf since it can't be inline AFAIK).

Comment 33 above says the same thing about this bug, i.e., wfm.

Retrieved September 16, 2012. Warriors orochi 3 ultimate characters.

Am I missing something when you say 'application/octet-stream works in local but not IMAP mailboxes'? What do you mean by 'works'?

However, I do still see the problem in bug 1418444 and maybe the attached patch above will fix it. Maybe that's what you are referring to. I will check that now.

OK, I'm confused then. Bug 1418444 is about saving. Well, let's see whether we can get that fixed.

I tried the patch for this bug ([review]) on the bug 1418444 problems and it didn't help. It also seems like there is an error in the patch in that the check for the string 'application/octet-string' uses PL_strcasecmp() and it should use !PL_strcasecmp(). I tried it with '!' and it still didn't make a difference.

I will now check again the fixes I had proposed in Bug 1418444.

Posted patch bug453805.patch - rebased — Details — Splinter Review

I can confirm that this patch doesn't help for bug 1418444. If ever you want to revive it for other purposes, please note comment #17.

What is test director. WFM as per comment #33.

Last Resolved: 2 months ago
You need to log in before you can comment on or make changes to this bug.
 gurusgreat © 2019